linux-kernel - RE: [PATCH] Bluetooth: btusb: Add support USB ALT 3 for WBS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08bd26e7da6549898da05b5ec3bb8b44@realtek.com>
Date:   Fri, 14 May 2021 02:31:45 +0000
From:   Hilda Wu <hildawu@...ltek.com>
To:     Marcel Holtmann <marcel@...tmann.org>
CC:     Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Bluetooth Kernel Mailing List 
        <linux-bluetooth@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Max Chou <max.chou@...ltek.com>,
        "alex_lu@...lsil.com.cn" <alex_lu@...lsil.com.cn>,
        KidmanLee <kidman@...ltek.com>
Subject: RE: [PATCH] Bluetooth: btusb: Add support USB ALT 3 for WBS

Hi Marcel,

Thank you!
I will propose a patch v2.

Regards,
Hilda

-----Original Message-----
From: Marcel Holtmann <marcel@...tmann.org> 
Sent: Thursday, May 13, 2021 11:13 PM
To: Hilda Wu <hildawu@...ltek.com>
Cc: Johan Hedberg <johan.hedberg@...il.com>; Luiz Augusto von Dentz <luiz.dentz@...il.com>; Bluetooth Kernel Mailing List <linux-bluetooth@...r.kernel.org>; open list <linux-kernel@...r.kernel.org>; Max Chou <max.chou@...ltek.com>; alex_lu@...lsil.com.cn; KidmanLee <kidman@...ltek.com>
Subject: Re: [PATCH] Bluetooth: btusb: Add support USB ALT 3 for WBS

Hi Hilda,

> Because mSBC frames do not need to be aligned to the SCO packet 
> boundary. Using USB ALT 3 let HCI payload >= 60 bytes, let mSBC data 
> satisfy 60 Bytes avoid payload unaligned situation and fixed some 
> headset no voise issue.
> 
> USB Alt 3 supported also need HFP support transparent MTU in 72 Bytes.
> 
> Signed-off-by: hildawu <hildawu@...ltek.com>

please use real name here.

> ---
> drivers/bluetooth/btusb.c | 7 +++++++
> 1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c 
> index 6f253378e893..872034e7a232 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -1752,6 +1752,13 @@ static void btusb_work(struct work_struct *work)
> 			 * which work with WBS at all.
> 			 */
> 			new_alts = btusb_find_altsetting(data, 6) ? 6 : 1;
> +			/* Because mSBC frames do not need to be aligned to the
> +			 * SCO packet boundary. If support the Alt 3, use the
> +			 * Alt 3 for HCI payload >= 60 Bytes let air packet
> +			 * data satisfy 60 bytes.
> +			 */
> +			if ((new_alts == 1) && (btusb_find_altsetting(data, 3)))
> +				new_alts = 3;

	if (new_alts == 1 && btusb_find_altsetting(..))
		..

Regards

Marcel

------Please consider the environment before printing this e-mail.