linux-kernel - Re: [PATCH v2 3/3] arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <089dfcb8-e821-da98-d93f-f3aea3d45ad3@baylibre.com>
Date:   Fri, 14 May 2021 16:29:02 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     khilman@...libre.com, jbrunet@...libre.com,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: meson-sm1: add Banana PI BPI-M5 board
 dts

On 05/05/2021 22:20, Martin Blumenstingl wrote:
> Hi Neil,
> 
> On Wed, May 5, 2021 at 9:32 AM Neil Armstrong <narmstrong@...libre.com> wrote:
>>
>> Banana Pi BPI-M5 is a credit card format SBC with the following features:
>> - Amlogic S905X3 quad core Cortex-A55
>> - Mali-G31 GPU
>> - 4GB LPDDR4
>> - 16GB eMMC flash
>> - 4 USB 3.0
>> - 1 GbE ethernet
>> - HDMI output
>> - 2x LEDS
>> - SDCard
>> - 2.5mm Jack with Stereo Audio + CVBS
>> - Infrared Received
>> - ADC Button
>> - GPIO Button
>> - 40 pins header + 3pins debug header
>>
>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
> one nit-pick below, but still this gets my:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> 
> [...]
>> +       /*
>> +        * WARNING: The USB Hub on the BPI-M54 needs a reset signal
> s/BPI-M5/BPI-M54/
> I am hoping that Kevin can fix this while applying

I'll send a v3 since I forgot to CC DT maintainers for patch 2 anyway..

Neil

> 
> 
> Best regards,
> Martin
>