linux-kernel - [RFC 1/2] dt-bindings: leds: Add color as a required property for lp55xx controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1621003477-11250-2-git-send-email-michal.vokac@ysoft.com>
Date:   Fri, 14 May 2021 16:44:36 +0200
From:   Michal Vokáč <michal.vokac@...ft.com>
To:     Pavel Machek <pavel@....cz>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>
Cc:     Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        Michal Vokáč <michal.vokac@...ft.com>,
        stable@...r.kernel.org
Subject: [RFC 1/2] dt-bindings: leds: Add color as a required property for lp55xx controller

Since addition of the multicolor LED framework in commit 92a81562e695
("leds: lp55xx: Add multicolor framework support to lp55xx") the color
property becomes required even if the multicolor framework is not enabled
and used.

Fix the binding documentation to reflect the real state.

Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
Cc: <stable@...r.kernel.org>
Cc: Pavel Machek <pavel@....cz>
Cc: Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc: linux-leds@...r.kernel.org
Signed-off-by: Michal Vokáč <michal.vokac@...ft.com>
---
 Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
index f552cd143d5b..e6bdd1cb615a 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
@@ -101,6 +101,7 @@ patternProperties:
         description: name of channel
 
 required:
+  - color
   - compatible
   - reg
 
@@ -127,6 +128,7 @@ examples:
                chan-name = "d1";
                led-cur = /bits/ 8 <0x14>;
                max-cur = /bits/ 8 <0x20>;
+               color = <LED_COLOR_ID_RED>;
            };
 
            led@1 {
@@ -134,6 +136,7 @@ examples:
                chan-name = "d2";
                led-cur = /bits/ 8 <0x14>;
                max-cur = /bits/ 8 <0x20>;
+               color = <LED_COLOR_ID_BLUE>;
            };
 
            led@2 {
@@ -141,6 +144,7 @@ examples:
                chan-name = "d3";
                led-cur = /bits/ 8 <0x14>;
                max-cur = /bits/ 8 <0x20>;
+               color = <LED_COLOR_ID_GREEN>;
            };
 
            led@3 {
@@ -148,6 +152,7 @@ examples:
                chan-name = "d4";
                led-cur = /bits/ 8 <0x14>;
                max-cur = /bits/ 8 <0x20>;
+               color = <LED_COLOR_ID_RED>;
            };
 
            led@4 {
@@ -155,6 +160,7 @@ examples:
                chan-name = "d5";
                led-cur = /bits/ 8 <0x14>;
                max-cur = /bits/ 8 <0x20>;
+               color = <LED_COLOR_ID_BLUE>;
            };
 
            led@5 {
@@ -162,6 +168,7 @@ examples:
                chan-name = "d6";
                led-cur = /bits/ 8 <0x14>;
                max-cur = /bits/ 8 <0x20>;
+               color = <LED_COLOR_ID_GREEN>;
            };
 
            led@6 {
@@ -169,6 +176,7 @@ examples:
                chan-name = "d7";
                led-cur = /bits/ 8 <0x14>;
                max-cur = /bits/ 8 <0x20>;
+               color = <LED_COLOR_ID_RED>;
            };
 
            led@7 {
@@ -176,6 +184,7 @@ examples:
                chan-name = "d8";
                led-cur = /bits/ 8 <0x14>;
                max-cur = /bits/ 8 <0x20>;
+               color = <LED_COLOR_ID_BLUE>;
            };
 
            led@8 {
@@ -183,6 +192,7 @@ examples:
                chan-name = "d9";
                led-cur = /bits/ 8 <0x14>;
                max-cur = /bits/ 8 <0x20>;
+               color = <LED_COLOR_ID_GREEN>;
            };
         };
 
-- 
2.7.4