linux-kernel - Re: [PATCH v2 4/5] dt-bindings: soc: rockchip: grf: add compatible for RK3308 USB grf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e995a144-1cbb-06c6-074f-2623bf31b003@gmail.com>
Date:   Fri, 14 May 2021 17:53:52 +0200
From:   Johan Jonker <jbx6244@...il.com>
To:     Tobias Schramm <t.schramm@...jaro.org>, linux-usb@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, linux-phy@...ts.infradead.org,
        devicetree@...r.kernel.org
Cc:     Rob Herring <robh+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/5] dt-bindings: soc: rockchip: grf: add compatible
 for RK3308 USB grf

Hi Tobias,

The grf serie is currently still under review. So things can change.
Must add a change log below a "---" in the commit message for rob+dt.
Maybe add a patch that fixes the reg size of "rockchip,rk3308-grf" as well?

Johan

On 5/14/21 5:00 PM, Tobias Schramm wrote:
> The RK3308 has a USB GRF.
> This patch adds a compatible string for it.
> 
> Signed-off-by: Tobias Schramm <t.schramm@...jaro.org>
> ---
>  Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> index 84bdaf88d5a6..df77bd2e6752 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> @@ -30,6 +30,7 @@ properties:
>                - rockchip,rk3288-grf
>                - rockchip,rk3308-core-grf
>                - rockchip,rk3308-detect-grf

> +              - rockchip,rk3308-usb2phy-grf
>                - rockchip,rk3308-grf

Sort alphabetically.

>                - rockchip,rk3328-grf
>                - rockchip,rk3328-usb2phy-grf
> 

Also allow usb2-phy as sub nodes name.

+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - rockchip,px30-usb2phy-grf
+              - rockchip,rk3228-grf

               - rockchip,rk3308-usb2phy-grf

+              - rockchip,rk3328-usb2phy-grf
+              - rockchip,rk3399-grf
+              - rockchip,rv1108-grf
+
+    then:
+      required:
+        - "#address-cells"
+        - "#size-cells"
+
+      patternProperties:
+        "usb2-phy@[0-9a-f]+$":
+          type: object
+
+          $ref: "/schemas/phy/phy-rockchip-inno-usb2.yaml#"
+
+          unevaluatedProperties: false

===
Heiko's sort rules:

compatible
reg
interrupts
[alphabetical]
status [if needed]

===

Sort #phy-cells below interrupt-names.


+				#phy-cells = <0>;
+				interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
+				interrupt-names = "linestate";