linux-kernel - Re: [PATCH v12 0/7] FPGA Security Manager Class Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <739f7fec-74a9-ca4e-ba9b-920bba2e6187@intel.com>
Date:   Fri, 14 May 2021 09:33:52 -0700
From:   Russ Weight <russell.h.weight@...el.com>
To:     Tom Rix <trix@...hat.com>, Moritz Fischer <mdf@...nel.org>
Cc:     linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
        lgoncalv@...hat.com, yilun.xu@...el.com, hao.wu@...el.com,
        matthew.gerlach@...el.com, richard.gong@...el.com
Subject: Re: [PATCH v12 0/7] FPGA Security Manager Class Driver

Moritz,

On 5/10/21 11:52 AM, Tom Rix wrote:
>
> On 5/10/21 10:37 AM, Moritz Fischer wrote:
>> On Mon, May 10, 2021 at 07:12:57AM -0700, Tom Rix wrote:
>>> On 5/3/21 2:35 PM, Russ Weight wrote:
>>>> The FPGA Security Manager class driver provides a common
>>>> API for user-space tools to manage updates for secure FPGA
>>>> devices. Device drivers that instantiate the FPGA Security
>>>> Manager class driver will interact with a HW secure update
>>>> engine in order to transfer new FPGA and BMC images to FLASH so
>>>> that they will be automatically loaded when the FPGA card reboots.
>>> Russ,
>>>
>>> These have my Reviewed-by, but since it has been a while, I am looking these
>>> over again.
>>>
>>> If you do not hear anything from me in the next couple of days, please
>>> assume everything is fine.
>>>
>>> Tom
>>>
>> I'll do one more one-over, if it looks good will apply end of the week,

I've been out of town for the Monday through Thursday of this week. Should I
address the few comments you had and resubmit before you take these? Or were
you thinking of making the changes yourself?

I'll submit an updated patch set before the end of the day today unless I
hear otherwise...

Thanks,
- Russ

>
> FWIW, my pass was fine.
>
> Thanks,
>
> Tom
>
>>
>> - Moritz
>>
>