linux-kernel - Re: [PATCH] nvme: remove redundant initialization of variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AA283AE0-3520-4FC2-86E9-7471CC3B9635@wdc.com>
Date:   Fri, 14 May 2021 04:43:15 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Colin King <colin.king@...onical.com>
CC:     Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvme: remove redundant initialization of variable ret


> On May 13, 2021, at 5:08 AM, Colin King <colin.king@...onical.com> wrote:
> 
> -    int ret = -EINVAL;
> +    int ret;
>    bool changed;

It'd be nice to move ret declaration after book changed.