linux-kernel - Re: [PATCH -next] percpu: make symbol 'pcpu_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YJ7k8zWAOoDA5i3t@google.com>
Date:   Fri, 14 May 2021 21:00:35 +0000
From:   Dennis Zhou <dennis@...nel.org>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Tejun Heo <tj@...nel.org>, Christoph Lameter <cl@...ux.com>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] percpu: make symbol 'pcpu_free_slot' static

Hello,

On Fri, May 14, 2021 at 06:39:52AM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> mm/percpu.c:138:5: warning:
>  symbol 'pcpu_free_slot' was not declared. Should it be static?
> 
> This symbol is not used outside of percpu.c, so marks it static.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  mm/percpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/percpu.c b/mm/percpu.c
> index a257c3efdf18..73c249f3b6a3 100644
> --- a/mm/percpu.c
> +++ b/mm/percpu.c
> @@ -135,7 +135,7 @@ static int pcpu_unit_size __ro_after_init;
>  static int pcpu_nr_units __ro_after_init;
>  static int pcpu_atom_size __ro_after_init;
>  int pcpu_nr_slots __ro_after_init;
> -int pcpu_free_slot __ro_after_init;
> +static int pcpu_free_slot __ro_after_init;
>  int pcpu_sidelined_slot __ro_after_init;
>  int pcpu_to_depopulate_slot __ro_after_init;
>  static size_t pcpu_chunk_struct_size __ro_after_init;
> 

Ah that's my bad. I've applied this for-5.14.

Thanks,
Dennis