linux-kernel - Re: [PATCH 5.10 160/530] arm64: dts: qcom: db845c: fix correct powerdown pin for WSA881x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210515081814.GA30461@amd>
Date:   Sat, 15 May 2021 10:18:14 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.10 160/530] arm64: dts: qcom: db845c: fix correct
 powerdown pin for WSA881x

Hi!

> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> [ Upstream commit c561740e7cfefaf3003a256f3a0cd9f8a069137c ]
> 
> WSA881x powerdown pin is connected to GPIO1 not gpio2, so correct this.
> This was working so far due to a shift bug in gpio driver, however
> once that is fixed this will stop working, so fix this!

I don't see the correspoing update to the driver this talks about.

Do we have corresponding driver in 5.10 and was it fixed to match?

Best regards,
									Pavel

> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -1015,7 +1015,7 @@
>  		left_spkr: wsa8810-left{
>  			compatible = "sdw10217201000";
>  			reg = <0 1>;
> -			powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>;
> +			powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>;
>  			#thermal-sensor-cells = <0>;
>  			sound-name-prefix = "SpkrLeft";
>  			#sound-dai-cells = <0>;
> @@ -1023,7 +1023,7 @@
>  
>  		right_spkr: wsa8810-right{
>  			compatible = "sdw10217201000";
> -			powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>;
> +			powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>;
>  			reg = <0 2>;
>  			#thermal-sensor-cells = <0>;
>  			sound-name-prefix = "SpkrRight";

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)