linux-kernel - Re: [PATCH 5.10 258/530] security: keys: trusted: fix TPM2 authorizations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210515082305.GC30461@amd>
Date:   Sat, 15 May 2021 10:23:06 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        James Bottomley <James.Bottomley@...senPartnership.com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.10 258/530] security: keys: trusted: fix TPM2
 authorizations

Hi!

Clean up unreachable code.

Signed-off-by: Pavel Machek (CIP) <pavel@...x.de>

diff --git a/security/keys/trusted-keys/trusted_tpm1.c b/security/keys/trusted-keys/trusted_tpm1.c
index 230c0b27b77d..5bae4ed73c4d 100644
--- a/security/keys/trusted-keys/trusted_tpm1.c
+++ b/security/keys/trusted-keys/trusted_tpm1.c
@@ -813,11 +813,7 @@ static int getoptions(char *c, struct trusted_key_payload *pay,
 				       opt->blobauth_len);
 				break;
 			}
-
 			return -EINVAL;
-
-			break;
-
 		case Opt_migratable:
 			if (*args[0].from == '0')
 				pay->migratable = 0;


-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)