linux-kernel - Re: [PATCH v3] drm/bridge/sii8620: fix dependency on extcon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG3jFyv5gBSG-xkQFDkQMhpqWa4-_e7GTb4pr4dJjZcNLW4ZQw@mail.gmail.com>
Date:   Sat, 15 May 2021 14:09:01 +0200
From:   Robert Foss <robert.foss@...aro.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, cw00.choi@...sung.com,
        m.purski@...sung.com, dri-devel <dri-devel@...ts.freedesktop.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v3] drm/bridge/sii8620: fix dependency on extcon

Hey Randy,

I missed sending out a notification, but this patch was merged into
drm-misc-next.

https://cgit.freedesktop.org/drm/drm-misc/commit/?id=08319adbdde15ef7cee1970336f63461254baa2a

On Sat, 15 May 2021 at 07:35, Randy Dunlap <rdunlap@...radead.org> wrote:
>
> On 4/19/21 10:54 AM, Randy Dunlap wrote:
> > On 4/19/21 10:10 AM, Randy Dunlap wrote:
> >> On 4/19/21 2:01 AM, Robert Foss wrote:
> >>> The DRM_SIL_SII8620 kconfig has a weak `imply` dependency
> >>> on EXTCON, which causes issues when sii8620 is built
> >>> as a builtin and EXTCON is built as a module.
> >>>
> >>> The symptoms are 'undefined reference' errors caused
> >>> by the symbols in EXTCON not being available
> >>> to the sii8620 driver.
> >>>
> >>> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
> >>> Signed-off-by: Robert Foss <robert.foss@...aro.org>
> >>> Reported-by: kernel test robot <lkp@...el.com>
> >>> ---
> >>>
> >>> LKP reported issue:
> >>> https://lore.kernel.org/lkml/202104040604.SSTe2Cxf-lkp@intel.com/
> >>>
> >>>
> >>> Changes since v1:
> >>>  - Fix typo on comment
> >>>
> >>> Changes since v2:
> >>>  - Randy: Changed from `depends` to `select`
> >>
> >> I don't know why my name is on that. I didn't
> >> suggest any change -- I just reported that v2
> >> had a problem.
> >>
> >>
> >>>
> >>>
> >>>  drivers/gpu/drm/bridge/Kconfig | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> >>> index 22a467abd3e9..70402da5cc70 100644
> >>> --- a/drivers/gpu/drm/bridge/Kconfig
> >>> +++ b/drivers/gpu/drm/bridge/Kconfig
> >>> @@ -169,7 +169,7 @@ config DRM_SIL_SII8620
> >>>     tristate "Silicon Image SII8620 HDMI/MHL bridge"
> >>>     depends on OF
> >>>     select DRM_KMS_HELPER
> >>> -   imply EXTCON
> >>> +   select EXTCON
> >>>     depends on RC_CORE || !RC_CORE
> >>>     help
> >>>       Silicon Image SII8620 HDMI/MHL bridge chip driver.
> >>
> >>
> >> Thanks. Works For Me.
> >>
> >> Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested
> >
> > Actually I can upgrade that to:
> >
> > Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
>
> Hi,
> Is anyone merging this patch?
>
> thanks.
> --
> ~Randy
>