linux-kernel - Re: [PATCH v2] clocksource/drivers/hyper-v: Re-enable VDSO_CLOCKMODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210515154335.lr4hrbcmt25u7m45@liuwe-devbox-debian-v2>
Date:   Sat, 15 May 2021 15:43:35 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Michael Kelley <mikelley@...rosoft.com>
Cc:     vkuznets <vkuznets@...hat.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Mohammed Gamal <mgamal@...hat.com>,
        Wei Liu <wei.liu@...nel.org>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Dexuan Cui <decui@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] clocksource/drivers/hyper-v: Re-enable
 VDSO_CLOCKMODE_HVCLOCK on X86

On Thu, May 13, 2021 at 01:29:12PM +0000, Michael Kelley wrote:
> From: Vitaly Kuznetsov <vkuznets@...hat.com> Sent: Thursday, May 13, 2021 12:33 AM
> > 
> > Mohammed reports (https://bugzilla.kernel.org/show_bug.cgi?id=213029)
> > the commit e4ab4658f1cf ("clocksource/drivers/hyper-v: Handle vDSO
> > differences inline") broke vDSO on x86. The problem appears to be that
> > VDSO_CLOCKMODE_HVCLOCK is an enum value in 'enum vdso_clock_mode' and
> > '#ifdef VDSO_CLOCKMODE_HVCLOCK' branch evaluates to false (it is not
> > a define). Use a dedicated HAVE_VDSO_CLOCKMODE_HVCLOCK define instead.
> > 
> > Suggested-by: Thomas Gleixner <tglx@...utronix.de>
> > Reported-by: Mohammed Gamal <mgamal@...hat.com>
> > Fixes: e4ab4658f1cf ("clocksource/drivers/hyper-v: Handle vDSO differences inline")
> > Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
[...]
> 
> Reviewed-by: Michael Kelley <mikelley@...rosoft.com>
> 

Applied to hyperv-fixes. Thanks.