linux-kernel - Re: [BUG] Shudown-time lockdep splat in next-20210514

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210515231926.GB4441@paulmck-ThinkPad-P17-Gen-1>
Date:   Sat, 15 May 2021 16:19:26 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Vlastimil Babka <vbabka@...e.cz>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        akpm@...ux-foundation.org, ming.lei@...hat.com, riel@...com,
        jweiner@...com, cl@...ux.com, penberg@...nel.org,
        rientjes@...gle.com, iamjoonsoo.kim@....com, glittao@...il.com
Subject: Re: [BUG] Shudown-time lockdep splat in next-20210514

On Sat, May 15, 2021 at 11:09:13PM +0200, Vlastimil Babka wrote:
> On 5/15/21 10:46 PM, Paul E. McKenney wrote:
> > Hello!
> > 
> > I am seeing the following lockdep splat in next-20210514.  It happens
> > at shutdown time in all rcutorture scenarios that enable lockdep.  It
> > happens consistently on 2-hour runs, and I am trying it on shorter runs.
> > If it reproduces nicely, I will try bisection.
> > 
> > In the meantime, does this ring a bell for anyone?
> 
> Hm, I think it will be
> ad36bafb3bcdf mm/slub: use stackdepot to save stack trace in objects
> 
> can you try this please?
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index 6b896b8c36f0..04824dae2e32 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -623,7 +623,7 @@ static void set_track(struct kmem_cache *s, void *object,
>  
>  	if (addr) {
>  #ifdef CONFIG_STACKDEPOT
> -		p->handle = save_stack_depot_trace(GFP_KERNEL);
> +		p->handle = save_stack_depot_trace(GFP_NOWAIT);
>  #endif
>  		p->addr = addr;
>  		p->cpu = smp_processor_id();

Works like a charm!

Tested-by: Paul E. McKenney <paulmck@...nel.org>

							Thanx, Paul