linux-kernel - Re: [PATCH v5 bpf-next 08/11] bpf: Support BPF_FUNC_get_socket_cookie() for BPF_PROG_TYPE_SK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210515042056.81877-1-kuniyu@amazon.co.jp>
Date:   Sat, 15 May 2021 13:20:56 +0900
From:   Kuniyuki Iwashima <kuniyu@...zon.co.jp>
To:     <kafai@...com>
CC:     <andrii@...nel.org>, <ast@...nel.org>, <benh@...zon.com>,
        <bpf@...r.kernel.org>, <daniel@...earbox.net>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <kuni1840@...il.com>, <kuniyu@...zon.co.jp>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v5 bpf-next 08/11] bpf: Support BPF_FUNC_get_socket_cookie() for BPF_PROG_TYPE_SK_REUSEPORT.

From:   Martin KaFai Lau <kafai@...com>
Date:   Fri, 14 May 2021 18:16:55 -0700
> On Mon, May 10, 2021 at 12:44:30PM +0900, Kuniyuki Iwashima wrote:
> > diff --git a/net/core/filter.c b/net/core/filter.c
> > index cae56d08a670..3d0f989f5d38 100644
> > --- a/net/core/filter.c
> > +++ b/net/core/filter.c
> > @@ -10135,6 +10135,8 @@ sk_reuseport_func_proto(enum bpf_func_id func_id,
> >  		return &sk_reuseport_load_bytes_proto;
> >  	case BPF_FUNC_skb_load_bytes_relative:
> >  		return &sk_reuseport_load_bytes_relative_proto;
> > +	case BPF_FUNC_get_socket_cookie:
> > +		return &bpf_get_socket_ptr_cookie_proto;
> >  	default:
> >  		return bpf_base_func_proto(func_id);
> >  	}
> > @@ -10164,6 +10166,10 @@ sk_reuseport_is_valid_access(int off, int size,
> >  	case offsetof(struct sk_reuseport_md, hash):
> >  		return size == size_default;
> >  
> > +	case offsetof(struct sk_reuseport_md, sk):
> > +		info->reg_type = ARG_PTR_TO_SOCKET;
> s/ARG_PTR_TO_SOCKET/PTR_TO_SOCKET/

I'll fix it.
Thank you.


> 
> > +		return size == sizeof(__u64);
> > +
> >  	/* Fields that allow narrowing */
> >  	case bpf_ctx_range(struct sk_reuseport_md, eth_protocol):
> >  		if (size < sizeof_field(struct sk_buff, protocol))