linux-kernel - Re: [PATCH] arm64: Define only {pud/pmd}_{set/clear}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae1be8a1-8412-1288-31d4-23dc2cf4e5e7@csgroup.eu>
Date:   Sat, 15 May 2021 08:28:25 +0200
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Nicholas Piggin <npiggin@...il.com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Mike Rapoport <rppt@...nel.org>, naresh.kamboju@...aro.org,
        linux-arch@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        sparclinux@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] arm64: Define only {pud/pmd}_{set/clear}_huge when
 usefull



Le 14/05/2021 à 23:42, Andrew Morton a écrit :
> On Fri, 14 May 2021 11:08:53 +0000 (UTC) Christophe Leroy <christophe.leroy@...roup.eu> wrote:
> 
>> When PUD and/or PMD are folded, those functions are useless
>> and we now have a stub in linux/pgtable.h
> 
> OK, help me out here please.  What patch does this fix?
> 

Both this one and the x86 one from the day before fix 1cff41494b15cd82c1ec418bb5c ("mm/pgtable: add 
stubs for {pmd/pub}_{set/clear}_huge")

I think both the x86 fix and the arm64 fix should be squashed into that patch at the end.

I checked, the only other architecture involving pud_set_huge() and friends is powerpc, and powerpc 
doesn't have this problem as it only defined those for book3s/64 platforms which have 4 level page 
tables by definition.

Thanks
Christophe