linux-kernel - Re: [PATCH 01/17] staging: add support for NUC WMI LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 16 May 2021 09:12:09 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        gregkh@...uxfoundation.org
Cc:     linuxarm@...wei.com, mauro.chehab@...wei.com,
        Pavel Machek <pavel@....cz>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH 01/17] staging: add support for NUC WMI LEDs

Hi Mauro,

On 5/16/21 3:53 AM, Mauro Carvalho Chehab wrote:
> diff --git a/drivers/staging/nuc-led/Kconfig b/drivers/staging/nuc-led/Kconfig
> new file mode 100644
> index 000000000000..0f870f45bf44
> --- /dev/null
> +++ b/drivers/staging/nuc-led/Kconfig
> @@ -0,0 +1,11 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +config LEDS_NUC_WMI
> +	tristate "Intel NUC WMI support for LEDs"
> +	depends on LEDS_CLASS
> +	depends on ACPI_WMI
> +	help
> +	  Enable this to support the Intel NUC WMI support for

Don't use "support" 2 times. Maybe:

	  Enable this to support the Intel NUC WMI interface for
or
	  Enable this to build the Intel NUC WMI support for


> +	  LEDs, starting from NUCi8 and upper devices.

Does "upper" mean "later"?  Or more advanced?  Not clear.


> +
> +	  To compile this driver as a module, choose M here.

thanks.
-- 
~Randy