linux-kernel - Re: [PATCH] scsi: target: tcmu: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 16 May 2021 18:24:16 +0200
From:   Bodo Stroesser <bostroesser@...il.com>
To:     kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, target-devel@...r.kernel.org
Subject: Re: [PATCH] scsi: target: tcmu: fix boolreturn.cocci warnings

On 16.05.21 01:03, kernel test robot wrote:
> From: kernel test robot <lkp@...el.com>
> 
> drivers/target/target_core_user.c:1424:9-10: WARNING: return of 0/1 in function 'tcmu_handle_completions' with return type bool
> 
>   Return statements in functions returning bool should use
>   true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Fixes: 9814b55cde05 ("scsi: target: tcmu: Return from tcmu_handle_completions() if cmd_id not found")
> CC: Bodo Stroesser <bostroesser@...il.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   c12a29ed9094b4b9cde8965c12850460b9a79d7c
> commit: 9814b55cde0588b6d9bc496cee43f87316cbc6f1 scsi: target: tcmu: Return from tcmu_handle_completions() if cmd_id not found
> :::::: branch date: 6 hours ago
> :::::: commit date: 2 weeks ago
> 
>   target_core_user.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -1421,7 +1421,7 @@ static bool tcmu_handle_completions(stru
>   
>   	if (test_bit(TCMU_DEV_BIT_BROKEN, &udev->flags)) {
>   		pr_err("ring broken, not handling completions\n");
> -		return 0;
> +		return false;
>   	}
>   
>   	mb = udev->mb_addr;
> 

Acked-by: Bodo Stroesser <bostroesser@...il.com>