linux-kernel - Re: [PATCH] HID: logitech-hidpp: initialize level variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a81900062b1e517ea20ecbf9324ddaf33e15f262.camel@riseup.net>
Date:   Sun, 16 May 2021 04:21:42 +0100
From:   Filipe Laíns <lains@...eup.net>
To:     trix@...hat.com, jikos@...nel.org, benjamin.tissoires@...hat.com,
        pedro@...rovanzella.com
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: logitech-hidpp: initialize level variable

On Fri, 2021-05-07 at 12:18 -0700, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Static analysis reports this representative problem
> 
> hid-logitech-hidpp.c:1356:23: warning: Assigned value is
>   garbage or undefined
>         hidpp->battery.level = level;
>                              ^ ~~~~~
> 
> In some cases, 'level' is never set in hidpp20_battery_map_status_voltage()
> Since level is not available on all hw, initialize level to unknown.
> 
> Fixes: be281368f297 ("hid-logitech-hidpp: read battery voltage from newer
> devices")
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/hid/hid-logitech-hidpp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-
> hidpp.c
> index 69670ca7e1e1..61635e629469 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -1265,6 +1265,7 @@ static int hidpp20_battery_map_status_voltage(u8
> data[3], int *voltage,
>         int status;
>  
>         long flags = (long) data[2];
> +       *level = POWER_SUPPLY_CAPACITY_LEVEL_UNKNOWN;
>  
>         if (flags & 0x80)
>                 switch (flags & 0x07) {

Hi Tom,

Taking a look at how this function is used, it does make sense to initialize the
level, thank you :)

Reviewed-by: Filipe Laíns <lains@...eup.net>

Cheers,
Filipe Laíns

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)