linux-kernel - Re: [PATCH v2] drivers: pnp: proc.c: Removed unnecessary variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 May 2021 16:49:15 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Anupama K Patil <anupamakpatil123@...il.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        B K Karthik <bkkarthik@...u.pes.edu>
Subject: Re: [PATCH v2] drivers: pnp: proc.c: Removed unnecessary variables

On Wed, Apr 28, 2021 at 9:39 PM Anupama K Patil
<anupamakpatil123@...il.com> wrote:
>
> de, e are two variables of the type 'struct proc_dir_entry'
> which can be removed to save memory. This also fixes a coding style
> issue reported by checkpatch where we are suggested to make assignment
> outside the if statement.
>
> Reviewed-by: Jaroslav Kysela <perex@...ex.cz>
> Signed-off-by: Anupama K Patil <anupamakpatil123@...il.com>
> ---
> v2: Added Reviewed-by: tag
>
>  drivers/pnp/isapnp/proc.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pnp/isapnp/proc.c b/drivers/pnp/isapnp/proc.c
> index 785a796430fa..1ae458c02656 100644
> --- a/drivers/pnp/isapnp/proc.c
> +++ b/drivers/pnp/isapnp/proc.c
> @@ -57,21 +57,20 @@ static const struct proc_ops isapnp_proc_bus_proc_ops = {
>  static int isapnp_proc_attach_device(struct pnp_dev *dev)
>  {
>         struct pnp_card *bus = dev->card;
> -       struct proc_dir_entry *de, *e;
>         char name[16];
>
> -       if (!(de = bus->procdir)) {
> +       if (!bus->procdir) {
>                 sprintf(name, "%02x", bus->number);
> -               de = bus->procdir = proc_mkdir(name, isapnp_proc_bus_dir);
> -               if (!de)
> +               bus->procdir = proc_mkdir(name, isapnp_proc_bus_dir);
> +               if (!bus->procdir)
>                         return -ENOMEM;
>         }
>         sprintf(name, "%02x", dev->number);
> -       e = dev->procent = proc_create_data(name, S_IFREG | S_IRUGO, de,
> +       dev->procent = proc_create_data(name, S_IFREG | S_IRUGO, bus->procdir,
>                                             &isapnp_proc_bus_proc_ops, dev);
> -       if (!e)
> +       if (!dev->procent)
>                 return -ENOMEM;
> -       proc_set_size(e, 256);
> +       proc_set_size(dev->procent, 256);
>         return 0;
>  }
>
> --

Applied as 5.14 material with edits in the subject and changelog, thanks!