linux-kernel - Re: [v2 PATCH 1/7] mm: memory: add orig_pmd to struct vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210517150922.GU3672@suse.de>
Date:   Mon, 17 May 2021 16:09:22 +0100
From:   Mel Gorman <mgorman@...e.de>
To:     Yang Shi <shy828301@...il.com>
Cc:     kirill.shutemov@...ux.intel.com, ziy@...dia.com, mhocko@...e.com,
        ying.huang@...el.com, hughd@...gle.com,
        gerald.schaefer@...ux.ibm.com, hca@...ux.ibm.com,
        gor@...ux.ibm.com, borntraeger@...ibm.com,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [v2 PATCH 1/7] mm: memory: add orig_pmd to struct vm_fault

On Tue, Apr 13, 2021 at 02:24:10PM -0700, Yang Shi wrote:
> Add orig_pmd to struct vm_fault so the "orig_pmd" parameter used by huge page
> fault could be removed, just like its PTE counterpart does.
> 
> Signed-off-by: Yang Shi <shy828301@...il.com>
>
> <SNIP>
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 25b9041f9925..9c5856f8cc81 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -547,6 +547,9 @@ struct vm_fault {
>  					 * the 'address'
>  					 */
>  	pte_t orig_pte;			/* Value of PTE at the time of fault */
> +	pmd_t orig_pmd;			/* Value of PMD at the time of fault,
> +					 * used by PMD fault only.
> +					 */
>  
>  	struct page *cow_page;		/* Page handler may use for COW fault */
>  	struct page *page;		/* ->fault handlers should return a

Could this be a union?

-- 
Mel Gorman
SUSE Labs