linux-kernel - Re: [PATCH] kernel/locking: make __down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210517143647.GA53990@hyeyoo>
Date:   Mon, 17 May 2021 23:36:47 +0900
From:   Hyeonggon Yoo <42.hyeyoo@...il.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     peterz@...radead.org, mingo@...hat.com, will@...nel.org,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] kernel/locking: make __down_common use flags previously
 saved

On Wed, May 12, 2021 at 09:09:34PM +0200, Ingo Molnar wrote:
> Yes, this is intentional, because if we get into __down_common() we have to 
> schedule, so we have to enable interrupts.

when I sent this patch I thought we have to match XXXX_irqsave with
XXXX_irqrestore, but that was my misunderstanding. I'm sorry for sending
patch saying that it's wrong without explicit evidence.

now I know it's wrong so I won't do that again.

thanks,
Hyeonggon