linux-kernel - Re: [PATCH 00/29] Speculative page faults (anon vmas only)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210517175750.GJ4441@paulmck-ThinkPad-P17-Gen-1>
Date:   Mon, 17 May 2021 10:57:50 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Michel Lespinasse <michel@...pinasse.org>
Cc:     Linux-MM <linux-mm@...ck.org>,
        Linux-Kernel <linux-kernel@...r.kernel.org>,
        Laurent Dufour <ldufour@...ux.ibm.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Michal Hocko <mhocko@...e.com>,
        Matthew Wilcox <willy@...radead.org>,
        Rik van Riel <riel@...riel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Joel Fernandes <joelaf@...gle.com>,
        Andy Lutomirski <luto@...nel.org>
Subject: Re: [PATCH 00/29] Speculative page faults (anon vmas only)

On Mon, May 03, 2021 at 11:11:18AM -0700, Michel Lespinasse wrote:
> On Fri, Apr 30, 2021 at 03:46:49PM -0700, Michel Lespinasse wrote:
> > I- Maple tree
> > 
> > I do not think there is any fundamental conflict between the maple
> > tree patches currently being considered, and this patchset.
> > I actually have a (very lightly tested) tree merging the two together,
> > which was a fairly easy merge. For those interested, I made this
> > available at my github, as the v5.12-maple-spf branch.
> 
> People were still confused about it, so the instructions to fetch this are:
> git fetch https://github.com/lespinasse/linux.git v5.12-maple-spf

Finally getting around to actually testing this, apologies for the
delay!

Just checking to see if I am in the right place.  The warning below is
easily fixed, but I figured that I should check.

							Thanx, Paul

------------------------------------------------------------------------

  CC      arch/x86/kernel/asm-offsets.s
In file included from ./include/linux/mmap_lock.h:10,
                 from ./include/linux/mm.h:18,
                 from ./include/linux/kallsyms.h:12,
                 from ./include/linux/bpf.h:20,
                 from ./include/linux/bpf-cgroup.h:5,
                 from ./include/linux/cgroup-defs.h:22,
                 from ./include/linux/cgroup.h:28,
                 from ./include/linux/memcontrol.h:13,
                 from ./include/linux/swap.h:9,
                 from ./include/linux/suspend.h:5,
                 from arch/x86/kernel/asm-offsets.c:13:
./include/linux/vmstat.h: In function ‘__mod_lruvec_page_state’:
./include/linux/vmstat.h:504:24: error: implicit declaration of function ‘page_pgdat’; did you mean ‘page_private’? [-Werror=implicit-function-declaration]
  __mod_node_page_state(page_pgdat(page), idx, val);
                        ^~~~~~~~~~
                        page_private
./include/linux/vmstat.h:504:24: warning: passing argument 1 of ‘__mod_node_page_state’ makes pointer from integer without a cast [-Wint-conversion]
  __mod_node_page_state(page_pgdat(page), idx, val);
                        ^~~~~~~~~~~~~~~~
./include/linux/vmstat.h:267:28: note: expected ‘struct pglist_data *’ but argument is of type ‘int’
 void __mod_node_page_state(struct pglist_data *, enum node_stat_item item, long);
                            ^~~~~~~~~~~~~~~~~~~~
./include/linux/vmstat.h: In function ‘mod_lruvec_page_state’:
./include/linux/vmstat.h:510:22: warning: passing argument 1 of ‘mod_node_page_state’ makes pointer from integer without a cast [-Wint-conversion]
  mod_node_page_state(page_pgdat(page), idx, val);
                      ^~~~~~~~~~~~~~~~
./include/linux/vmstat.h:275:26: note: expected ‘struct pglist_data *’ but argument is of type ‘int’
 void mod_node_page_state(struct pglist_data *, enum node_stat_item, long);
                          ^~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/kallsyms.h:12,
                 from ./include/linux/bpf.h:20,
                 from ./include/linux/bpf-cgroup.h:5,
                 from ./include/linux/cgroup-defs.h:22,
                 from ./include/linux/cgroup.h:28,
                 from ./include/linux/memcontrol.h:13,
                 from ./include/linux/swap.h:9,
                 from ./include/linux/suspend.h:5,
                 from arch/x86/kernel/asm-offsets.c:13:
./include/linux/mm.h: At top level:
./include/linux/mm.h:1568:26: error: conflicting types for ‘page_pgdat’
 static inline pg_data_t *page_pgdat(const struct page *page)
                          ^~~~~~~~~~
In file included from ./include/linux/mmap_lock.h:10,
                 from ./include/linux/mm.h:18,
                 from ./include/linux/kallsyms.h:12,
                 from ./include/linux/bpf.h:20,
                 from ./include/linux/bpf-cgroup.h:5,
                 from ./include/linux/cgroup-defs.h:22,
                 from ./include/linux/cgroup.h:28,
                 from ./include/linux/memcontrol.h:13,
                 from ./include/linux/swap.h:9,
                 from ./include/linux/suspend.h:5,
                 from arch/x86/kernel/asm-offsets.c:13:
./include/linux/vmstat.h:504:24: note: previous implicit declaration of ‘page_pgdat’ was here
  __mod_node_page_state(page_pgdat(page), idx, val);
                        ^~~~~~~~~~
cc1: some warnings being treated as errors