linux-kernel - Re: [PATCH] MIPS: alchemy: xxs1500: add gpio-au1000.h header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 May 2021 09:49:53 +0200
From:   Manuel Lauss <manuel.lauss@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Linux-MIPS <linux-mips@...r.kernel.org>,
        Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [PATCH] MIPS: alchemy: xxs1500: add gpio-au1000.h header file

Hello,

On Mon, May 17, 2021 at 2:01 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> board-xxs1500.c references 2 functions without declaring them, so add
> the header file to placate the build.
>
> ../arch/mips/alchemy/board-xxs1500.c: In function 'board_setup':
> ../arch/mips/alchemy/board-xxs1500.c:56:2: error: implicit declaration of function 'alchemy_gpio1_input_enable' [-Werror=implicit-function-declaration]
>    56 |  alchemy_gpio1_input_enable();
> ../arch/mips/alchemy/board-xxs1500.c:57:2: error: implicit declaration of function 'alchemy_gpio2_enable'; did you mean 'alchemy_uart_enable'? [-Werror=implicit-function-declaration]
>    57 |  alchemy_gpio2_enable();
>
> Fixes: 8e026910fcd4 ("MIPS: Alchemy: merge GPR/MTX-1/XXS1500 board code into single files")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> Cc: linux-mips@...r.kernel.org
> Cc: Manuel Lauss <manuel.lauss@...glemail.com>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> ---
>  arch/mips/alchemy/board-xxs1500.c |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20210514.orig/arch/mips/alchemy/board-xxs1500.c
> +++ linux-next-20210514/arch/mips/alchemy/board-xxs1500.c
> @@ -18,6 +18,7 @@
>  #include <asm/reboot.h>
>  #include <asm/setup.h>
>  #include <asm/mach-au1x00/au1000.h>
> +#include <asm/mach-au1x00/gpio-au1000.h>

Acked-by: Manuel Lauss <manuel.lauss@...il.com>

Thank you!
     Manuel