[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75Vcj3_ePO1=+p0FRGk018TYG-LeA2=xtzENJUuN5sBGGGA@mail.gmail.com>
Date: Tue, 18 May 2021 00:46:38 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Sander Vanheule <sander@...nheule.net>
Cc: Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
Lee Jones <lee.jones@...aro.org>,
Mark Brown <broonie@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J . Wysocki" <rafael@...nel.org>,
Michael Walle <michael@...le.cc>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <bgolaszewski@...libre.com>,
Linux LED Subsystem <linux-leds@...r.kernel.org>,
devicetree <devicetree@...r.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
Andrew Lunn <andrew@...n.ch>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 6/7] pinctrl: Add RTL8231 pin control and GPIO support
On Tue, May 18, 2021 at 12:42 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Mon, May 17, 2021 at 10:28 PM Sander Vanheule <sander@...nheule.net> wrote:
The rest of the review is here (hit the send before finished).
...
> > + int err = 0;
>
> Check entire series for unnecessary assignments.They
They even may hide a mistake.
...
> > +static int rtl8231_pinctrl_probe(struct platform_device *pdev)
> > +{
> > + ctrl->map = dev_get_regmap(dev->parent, NULL);
> > + if (IS_ERR_OR_NULL(ctrl->map)) {
> > + dev_err(dev, "failed to retrieve regmap\n");
> > + if (!ctrl->map)
> > + return -ENODEV;
> > + else
> > + return PTR_ERR(ctrl->map);
> > + }
Simply split the outer conditional to two.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists