linux-kernel - Re: [PATCH 1/4] bootconfig: Change array value to use child node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 May 2021 08:42:17 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Devin Moore <devinmoore@...gle.com>
Subject: Re: [PATCH 1/4] bootconfig: Change array value to use child node

On Mon, 17 May 2021 11:24:34 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Sun, 16 May 2021 23:55:31 +0900
> Masami Hiramatsu <mhiramat@...nel.org> wrote:
> 
> > Change array value to use child node of the xbc_node tree
> > instead of next node.
> 
> Hi Masami,
> 
> This says what you did, not why you did it. Can you add a comment about
> what the purpose of this change was?

Ah, yes.
Actually, this is an internal (and intermediate) change.
For co-existing a value with subkeys, the barrier is an array of the value,
because both of subkeys and the array elements are using "next" field of
the xbc_node. Thus this changes the array values to use "child" field in
the array case.

Thank you,

> 
> Thanks!
> 
> -- Steve
> 
> 
> > 
> > Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
> > ---
> >  tools/bootconfig/main.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >


-- 
Masami Hiramatsu <mhiramat@...nel.org>