linux-kernel - Re: [PATCH 1/2] ASoC: dwc: add a quirk DW_I2S_QUIRK_STOP_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c875eae-88f2-5bc7-849b-f1c4afb29dbe@gmail.com>
Date:   Mon, 17 May 2021 11:07:09 +0300
From:   Péter Ujfalusi <peter.ujfalusi@...il.com>
To:     "Mukunda,Vijendar" <vijendar.mukunda@....com>,
        Mark Brown <broonie@...nel.org>
Cc:     alsa-devel@...a-project.org, amistry@...gle.com,
        nartemiev@...gle.com, Alexander.Deucher@....com,
        Basavaraj.Hiregoudar@....com, Sunil-kumar.Dommati@....com,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ASoC: dwc: add a quirk DW_I2S_QUIRK_STOP_ON_SHUTDOWN
 to dwc driver

On 10/05/2021 20:27, Mukunda,Vijendar wrote:
>> Hardware signal broken between ACP and Designware I2S controller with
>> re-ordering the sequence.
>>   > It is surely not a designware IP issue, trying to solve it there
>> is wrong.
>>>
>> As it's not a designware IP issue, initially we started idea with
>> introducing quirk that applies for this ACP version based AMD platforms.
>>
> 
> Hi Peter,
> 
> Any suggestion on the work around for this issue?
> How about declaring a flag in sound card structure and this flag will be
> set in stoneyridge machine driver.

This can only be solved in the core, that's clear.
If this issue only affects this version of ACP with dw I2S (the same ACP
version works fine with other audio IP), then it is more like machine
driver level of quirk.
If this ACP have the same issue with other audio IPs as well then it is
platform quirk.
If the this ACP is only used in this setup then I would consider machine
level quirk as it might be simpler to implement.

Other thing to consider is how other setups with similar issues can use
the new quirk/flag... Some might need to make sure that a component is
first, not last for example.

> Based on flag check trigger stop sequence will be re-ordered.
> 
> Thanks,
> Vijendar

-- 
Péter