linux-kernel - Re: [PATCH 07/34] net: cadence: macb_ptp: Demote non-compliant kernel-doc headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7dd358d-1500-a2c9-e29f-bc0e0d8ef59c@huawei.com>
Date:   Mon, 17 May 2021 09:48:44 +0800
From:   Yang Shen <shenyang39@...wei.com>
To:     <Nicolas.Ferre@...rochip.com>, <davem@...emloft.net>,
        <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <Claudiu.Beznea@...rochip.com>
Subject: Re: [PATCH 07/34] net: cadence: macb_ptp: Demote non-compliant
 kernel-doc headers



On 2021/5/15 20:46, Nicolas.Ferre@...rochip.com wrote:
> On 15/05/2021 at 12:53, Yang Shen wrote:
>> Fixes the following W=1 kernel build warning(s):
>>
>>   drivers/net/ethernet/cadence/macb_ptp.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>>
>> Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>
>
> Ok, if it raises a warning.
>
> But I would prefer that you add drivers/net/ethernet/cadence/macb_pci.c
> with same change to a combined patch.
>
> Regards,
>    Nicolas
>

OK，The compiler missed this warning at 
drivers/net/ethernet/cadence/macb_pci.c.
I'll fix this in the next version.

Thanks,
     Yang

>
>> Cc: Claudiu Beznea <claudiu.beznea@...rochip.com>
>> Signed-off-by: Yang Shen <shenyang39@...wei.com>
>> ---
>>   drivers/net/ethernet/cadence/macb_ptp.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb_ptp.c b/drivers/net/ethernet/cadence/macb_ptp.c
>> index 283918a..5c368a9 100644
>> --- a/drivers/net/ethernet/cadence/macb_ptp.c
>> +++ b/drivers/net/ethernet/cadence/macb_ptp.c
>> @@ -1,5 +1,5 @@
>>   // SPDX-License-Identifier: GPL-2.0-only
>> -/**
>> +/*
>>    * 1588 PTP support for Cadence GEM device.
>>    *
>>    * Copyright (C) 2017 Cadence Design Systems - https://www.cadence.com
>> --
>> 2.7.4
>>
>
>