linux-kernel - Re: [PATCH 5.10 160/530] arm64: dts: qcom: db845c: fix correct powerdown pin for WSA881x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55d58470-f606-8c75-1f00-a2eb09314081@linaro.org>
Date:   Mon, 17 May 2021 09:46:49 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Pavel Machek <pavel@...x.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Sasha Levin <sashal@...nel.org>, bgolaszewski@...libre.com,
        linus.walleij@...aro.org
Subject: Re: [PATCH 5.10 160/530] arm64: dts: qcom: db845c: fix correct
 powerdown pin for WSA881x

+ Adding Linus W and Bartosz to CC.

On 15/05/2021 09:18, Pavel Machek wrote:
> Hi!
> 
>> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>>
>> [ Upstream commit c561740e7cfefaf3003a256f3a0cd9f8a069137c ]
>>
>> WSA881x powerdown pin is connected to GPIO1 not gpio2, so correct this.
>> This was working so far due to a shift bug in gpio driver, however
>> once that is fixed this will stop working, so fix this!
> 
> I don't see the correspoing update to the driver this talks about.
> 
> Do we have corresponding driver in 5.10 and was it fixed to match?

This corresponding gpio driver patch was submitted along with the 
original fix, however it looks like it was not picked up yet.

https://www.spinics.net/lists/linux-gpio/msg59264.html

Bartosz/Linus W, Do you want me to resend this?

--srini

> 
> Best regards,
> 									Pavel
> 
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> @@ -1015,7 +1015,7 @@
>>   		left_spkr: wsa8810-left{
>>   			compatible = "sdw10217201000";
>>   			reg = <0 1>;
>> -			powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>;
>> +			powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>;
>>   			#thermal-sensor-cells = <0>;
>>   			sound-name-prefix = "SpkrLeft";
>>   			#sound-dai-cells = <0>;
>> @@ -1023,7 +1023,7 @@
>>   
>>   		right_spkr: wsa8810-right{
>>   			compatible = "sdw10217201000";
>> -			powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>;
>> +			powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>;
>>   			reg = <0 2>;
>>   			#thermal-sensor-cells = <0>;
>>   			sound-name-prefix = "SpkrRight";
>