linux-kernel - Re: [PATCH RFC 5/9] arm64: dts: rockchip: rk1808k-toybrick-m0: Suppress vGIC interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 May 2021 10:29:15 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Andreas Färber <afaerber@...e.de>
Cc:     linux-rockchip@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>, devicetree@...r.kernel.org
Subject: Re: [PATCH RFC 5/9] arm64: dts: rockchip: rk1808k-toybrick-m0: Suppress vGIC interrupt

On Mon, 17 May 2021 00:05:47 +0100,
Andreas Färber <afaerber@...e.de> wrote:
> 
> Avoid the kernel getting stuck after:
> 
> [    1.175956] kvm [1]: IPA Size Limit: 40 bits
> [    1.177164] kvm [1]: vgic-v2@...20000
> [    1.177545] kvm [1]: GIC system register CPU interface enabled
> 
> or when dropping GICV reg entry:
> 
> [    1.176001] kvm [1]: IPA Size Limit: 40 bits
> [    1.177191] kvm [1]: GICv3: no GICV resource entry
> [    1.177664] kvm [1]: disabling GICv2 emulation
> [    1.178115] kvm [1]: GIC system register CPU interface enabled
> 
> Signed-off-by: Andreas Färber <afaerber@...e.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk1808k-toybrick-m0.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk1808k-toybrick-m0.dts b/arch/arm64/boot/dts/rockchip/rk1808k-toybrick-m0.dts
> index 2f8075d2391c..15293a8576c6 100644
> --- a/arch/arm64/boot/dts/rockchip/rk1808k-toybrick-m0.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk1808k-toybrick-m0.dts
> @@ -48,6 +48,10 @@ &cpu1 {
>  	cpu-supply = <&vdd_cpu>;
>  };
>  
> +&gic {
> +	/delete-property/ interrupts;
> +};
> +
>  &uart2 {
>  	status = "okay";
>  	clocks = <&xin24m>;

As I said in my reply to the cover letter, this is not an acceptable
outcome. Please add some debug to kvm_vgic_hyp_init() to understand
where this is hanging and why.

	M.

-- 
Without deviation from the norm, progress is not possible.