linux-kernel - [RFC PATCH 00/15] Handle virtio_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 May 2021 17:34:13 +0800
From:   Xie Yongji <xieyongji@...edance.com>
To:     mst@...hat.com, jasowang@...hat.com, stefanha@...hat.com
Cc:     amit@...nel.org, arei.gonglei@...wei.com, airlied@...ux.ie,
        kraxel@...hat.com, jean-philippe@...aro.org, ohad@...ery.com,
        bjorn.andersson@...aro.org, david@...hat.com, vgoyal@...hat.com,
        miklos@...redi.hu, lucho@...kov.net, asmadeus@...ewreck.org,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: [RFC PATCH 00/15] Handle virtio_device_ready() failure

Now we would trigger a BUG_ON() when we get an invalid status in
virtio_device_ready() during probe and suspend/resume. But
returning invalid status might happen in VDUSE[1] case where
the device becomes untrusted. So this series tries to remove the 
BUG_ON() and return error to the caller so that the device driver
can handle the error correctly.

Now this series is based on my another fix[2].

[1] https://lore.kernel.org/kvm/20210331080519.172-1-xieyongji@bytedance.com/
[2] https://lore.kernel.org/lkml/20210517083557.172-1-xieyongji@bytedance.com/

Xie Yongji (15):
  virtio_config: Add return value to virtio_device_ready()
  virtio-blk: Handle virtio_device_ready() failure
  virtio_console: Handle virtio_device_ready() failure
  virtio_crypto: Handle virtio_device_ready() failure
  drm/virtio: Handle virtio_device_ready() failure
  virtio-iommu: Handle virtio_device_ready() failure
  virtio-net: Handle virtio_device_ready() failure
  rpmsg: virtio: Handle virtio_device_ready() failure
  virtio_scsi: Handle virtio_device_ready() failure
  virtio: Handle virtio_device_ready() failure
  virtio-balloon: Handle virtio_device_ready() failure
  virtio-input: Handle virtio_device_ready() failure
  virtio-mem: Handle virtio_device_ready() failure
  virtiofs: Handle virtio_device_ready() failure
  9p/trans_virtio: Handle virtio_device_ready() failure

 drivers/block/virtio_blk.c                 | 13 +++++++++++--
 drivers/char/virtio_console.c              | 14 ++++++++++++--
 drivers/crypto/virtio/virtio_crypto_core.c |  8 ++++++--
 drivers/gpu/drm/virtio/virtgpu_kms.c       |  8 +++++++-
 drivers/iommu/virtio-iommu.c               |  4 +++-
 drivers/net/virtio_net.c                   | 19 +++++++++++++-----
 drivers/rpmsg/virtio_rpmsg_bus.c           | 31 ++++++++++++++++++------------
 drivers/scsi/virtio_scsi.c                 | 13 ++++++++++---
 drivers/virtio/virtio.c                    |  9 +++++++--
 drivers/virtio/virtio_balloon.c            | 13 +++++++++++--
 drivers/virtio/virtio_input.c              | 11 +++++++++--
 drivers/virtio/virtio_mem.c                |  6 +++++-
 fs/fuse/virtio_fs.c                        |  4 +++-
 include/linux/virtio_config.h              |  8 ++++++--
 net/9p/trans_virtio.c                      |  6 +++++-
 15 files changed, 128 insertions(+), 39 deletions(-)

-- 
2.11.0