linux-kernel - Re: [PATCH] kbuild: dummy-tools: adjust to stricter stackprotector check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQewGP4aRU-Xm60wTZuJ5-u2jPcgxNSBxUP0VjzprtMhg@mail.gmail.com>
Date:   Mon, 17 May 2021 11:48:52 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...e.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: dummy-tools: adjust to stricter stackprotector check

On Sat, May 15, 2021 at 7:58 PM Michal Kubecek <mkubecek@...e.cz> wrote:
>
> Commit 3fb0fdb3bbe7 ("x86/stackprotector/32: Make the canary into a regular
> percpu variable") modified the stackprotector check on 32-bit x86 to check
> if gcc supports using %fs as canary. Adjust dummy-tools gcc script to pass
> this new test by returning "%fs" rather than "%gs" if it detects
> -mstack-protector-guard-reg=fs on command line.
>
> Fixes: 3fb0fdb3bbe7 ("x86/stackprotector/32: Make the canary into a regular percpu variable")
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>


Applied to linux-kbuild/fixes.
Thanks.

> ---
>  scripts/dummy-tools/gcc | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc
> index f6d543725f1e..b2483149bbe5 100755
> --- a/scripts/dummy-tools/gcc
> +++ b/scripts/dummy-tools/gcc
> @@ -76,7 +76,11 @@ fi
>  if arg_contain -S "$@"; then
>         # For scripts/gcc-x86-*-has-stack-protector.sh
>         if arg_contain -fstack-protector "$@"; then
> -               echo "%gs"
> +               if arg_contain -mstack-protector-guard-reg=fs "$@"; then
> +                       echo "%fs"
> +               else
> +                       echo "%gs"
> +               fi
>                 exit 0
>         fi
>
> --
> 2.31.1
>


-- 
Best Regards
Masahiro Yamada