linux-kernel - Re: [PATCH v2 1/2] platform/x86: samsung-laptop: use octal numbers for rwx file permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YKI/HD7qZB6Seh/+@ninjato>
Date:   Mon, 17 May 2021 12:02:04 +0200
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Corentin Chary <corentin.chary@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <mgross@...ux.intel.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] platform/x86: samsung-laptop: use octal numbers
 for rwx file permissions


> > > -       debugfs_create_file("call", S_IFREG | S_IRUGO, root, samsung,
> > > +       debugfs_create_file("call", S_IFREG | 0444, root, samsung,
> 
> Actually you may drop IFREG as well as debugfs will add it if there is
> no conflicting file type defined.

Oh, I missed this back then. Quoting only relevant parts of a message
helps me to avoid that ;)

I will add this, to patch 2, though. This is only a plain conversion. v3
coming in a minute.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)