linux-kernel - Re: [PATCH 2/3] power: supply: rt5033_battery: Fix device tree enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YKJJnRI0Jt/OdMJv@gerhold.net>
Date:   Mon, 17 May 2021 12:46:53 +0200
From:   Stephan Gerhold <stephan@...hold.net>
To:     Sebastian Reichel <sre@...nel.org>,
        Lee Jones <lee.jones@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Beomho Seo <beomho.seo@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH 2/3] power: supply: rt5033_battery: Fix device tree
 enumeration

On Mon, May 17, 2021 at 12:35:53PM +0200, Stephan Gerhold wrote:
> The fuel gauge in the RT5033 PMIC has its own I2C bus and interrupt
> line. Therefore, it is not actually part of the RT5033 MFD and needs
> its own of_match_table to probe properly.
> 
> Also, given that it's independent of the MFD, there is actually
> no need to make the Kconfig depend on MFD_RT5033. Although the driver
> uses the shared <linux/mfd/rt5033.h> header, there is no compile
> or runtime dependency on the RT5033 MFD driver.
> 
> Cc: Beomho Seo <beomho.seo@...sung.com>
> Cc: Chanwoo Choi <cw00.choi@...sung.com>
> Fixes: b847dd96e659 ("power: rt5033_battery: Add RT5033 Fuel gauge device driver")
> Signed-off-by: Stephan Gerhold <stephan@...hold.net>
> ---
>  drivers/power/supply/Kconfig          | 3 ++-
>  drivers/power/supply/rt5033_battery.c | 7 +++++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index e696364126f1..20a2f93252f9 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -712,7 +712,8 @@ config BATTERY_GOLDFISH
>  
>  config BATTERY_RT5033
>  	tristate "RT5033 fuel gauge support"
> -	depends on MFD_RT5033
> +	depends on I2C
> +	select REGMAP_I2C
>  	help
>  	  This adds support for battery fuel gauge in Richtek RT5033 PMIC.
>  	  The fuelgauge calculates and determines the battery state of charge
> diff --git a/drivers/power/supply/rt5033_battery.c b/drivers/power/supply/rt5033_battery.c
> index f330452341f0..11eb9ad66ea9 100644
> --- a/drivers/power/supply/rt5033_battery.c
> +++ b/drivers/power/supply/rt5033_battery.c
> @@ -164,9 +164,16 @@ static const struct i2c_device_id rt5033_battery_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, rt5033_battery_id);
>  
> +static const struct of_device_id rt5033_battery_of_match[] = {
> +	{ .compatible = "richtek,rt5033-battery", },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, rt5033_battery_dt_match);

s/dt_match/of_match

Ugh, I shouldn't do any last-minute renames and then only compile-test
with modules disabled. :(

Sorry, please ignore this one, will send a v2 shortly...

Stephan