linux-kernel - [PATCH -next] bus: qcom: Add missing clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20210517110922.474849-1-yangyingliang@huawei.com>
Date:   Mon, 17 May 2021 19:09:22 +0800
From:   Yang Yingliang <yangyingliang@...wei.com>
To:     <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>
CC:     <bjorn.andersson@...aro.org>
Subject: [PATCH -next] bus: qcom: Add missing clk_disable_unprepare() on error path

After calling clk_prepare_enable(), clk_disable_unprepare() need
be called when read csindex failed.

Fixes: 335a12754808 ("bus: qcom: add EBI2 driver")
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
---
 drivers/bus/qcom-ebi2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c
index 0b8f53a688b8..3cffac13bc5f 100644
--- a/drivers/bus/qcom-ebi2.c
+++ b/drivers/bus/qcom-ebi2.c
@@ -355,7 +355,7 @@ static int qcom_ebi2_probe(struct platform_device *pdev)
 		ret = of_property_read_u32(child, "reg", &csindex);
 		if (ret) {
 			of_node_put(child);
-			return ret;
+			goto err_disable_clk;
 		}
 
 		if (csindex > 5) {
-- 
2.25.1