linux-kernel - Re: Re: Re: Re: Re: [PATCH] HID: usbhid: enable remote wakeup for mouse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YKJXDT/xuzw1Gi+8@kroah.com>
Date:   Mon, 17 May 2021 13:44:13 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     马强 <maqianga@...ontech.com>
Cc:     jikos <jikos@...nel.org>,
        "benjamin.tissoires " <benjamin.tissoires@...hat.com>,
        linux-usb <linux-usb@...r.kernel.org>,
        linux-input <linux-input@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: Re: Re: Re: Re: [PATCH] HID: usbhid: enable remote wakeup for
 mouse

On Mon, May 17, 2021 at 07:28:15PM +0800, 马强 wrote:
> 
> > Given that you have not tested this change, why should we take this? 
> 
> 
> I have tested this change.
> 
> Before adding the patch, "dev->power.should_wakeup" is disabled after the
> insertion of the USB mouse,
> 
> and after adding the patch, "dev->power.should_wakeup" is enabled after the
> insertion of the USB mouse.
> 
>  
>  
> 

How many different mice did you test this on?  What specific models?

Again, this is not a requirement of all Mice devices, as it is not a
requirement of the USB specification, which is why we can not enable it
for all devices of this type.

And no other operating system does so either that I know of.  Do you
know of one?

thanks,

greg k-h