linux-kernel - Re: [PATCH v2 1/1] ata: Replace inclusion of kernel.h by bits.h in the header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YKJfgDKetSV6OQxm@smile.fi.intel.com>
Date:   Mon, 17 May 2021 15:20:16 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH v2 1/1] ata: Replace inclusion of kernel.h by bits.h in
 the header

On Fri, Apr 09, 2021 at 06:34:56PM +0300, Andy Shevchenko wrote:
> ata.h uses BIT() macro, hence bits.h must be included. Otherwise
> there is no need to have kernel.h included, I do not see any
> direct users of it in ata.h. Hence replace inclusion of kernel.h.

Jens, can we now apply this one?

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> v2: replaced kernel.h by bits.h (lkp), tested allmod/yesconfig on x86_64 (Jens)
>  include/linux/ata.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index 6e67aded28f8..1b44f40c7700 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -13,7 +13,7 @@
>  #ifndef __LINUX_ATA_H__
>  #define __LINUX_ATA_H__
>  
> -#include <linux/kernel.h>
> +#include <linux/bits.h>
>  #include <linux/string.h>
>  #include <linux/types.h>
>  #include <asm/byteorder.h>
> -- 
> 2.30.2
> 

-- 
With Best Regards,
Andy Shevchenko