linux-kernel - [PATCH] Documentation: checkpatch: add description if no filenames are given

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1621224036-32092-1-git-send-email-yangtiezhu@loongson.cn>
Date:   Mon, 17 May 2021 12:00:36 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     Jonathan Corbet <corbet@....net>, Joe Perches <joe@...ches.com>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: [PATCH] Documentation: checkpatch: add description if no filenames are given

After commit 45107ff6d526 ("checkpatch: if no filenames then read stdin"),
if no filenames are given, it will read patch from stdin rather than exit
directly, it is a bit confusing whether the script hangs, I do not quite
know what to do next util I understand the code logic.

At the beginning, I want to print some info if no filenames are given [1],
but as Joe Perches said, this is unnecessary. It's like trying to make cat
without command line arguments emit something.

So as Lukas Bulwahn suggested, add description for somebody that actually
reads the available kernel documentation on checkpatch.

[1] https://lore.kernel.org/patchwork/patch/1429026/

Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
---
 Documentation/dev-tools/checkpatch.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-tools/checkpatch.rst
index 51fed1b..181b95e 100644
--- a/Documentation/dev-tools/checkpatch.rst
+++ b/Documentation/dev-tools/checkpatch.rst
@@ -210,6 +210,8 @@ Available options:

    Display the help text.

+When FILE is -, or no filenames are given, read standard input.
+
 Message Levels
 ==============

-- 
2.1.0