linux-kernel - Re: [PATCH v1 1/1] i2c: core: Make debug message even more debuggish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YKJ1xShXHesBnII+@smile.fi.intel.com>
Date:   Mon, 17 May 2021 16:55:17 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Wolfram Sang <wsa@...nel.org>
Subject: Re: [PATCH v1 1/1] i2c: core: Make debug message even more debuggish

On Wed, Apr 28, 2021 at 05:57:51PM +0300, Andy Shevchenko wrote:
> One may notice that dev_printk(KERN_DEBUG ...) is *not* an equivalent
> to dev_dbg(). It will be printed whenever loglevel is high enough.
> And currently it will be the only message in the I²C core in some
> configurations that got printed under above conditions.
> 
> Moving to dev_dbg() will hide it in the configurations where Dynamic Debug
> is enabled and hence align with all other debug messages in the I²C core..

Wolfram, any comment on this?

-- 
With Best Regards,
Andy Shevchenko