linux-kernel - Re: [PATCH] LOCKDEP: use depends on LOCKDEP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1284b997-b9da-769f-2d36-4d4232c7df88@redhat.com>
Date:   Mon, 17 May 2021 10:02:18 -0400
From:   Waiman Long <llong@...hat.com>
To:     Ingo Molnar <mingo@...nel.org>,
        Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
        Boqun Feng <boqun.feng@...il.com>,
        Chris Zankel <chris@...kel.net>,
        Max Filippov <jcmvbkbc@...il.com>,
        linux-xtensa@...ux-xtensa.org,
        Johannes Berg <johannes@...solutions.net>,
        Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>,
        Anton Ivanov <anton.ivanov@...bridgegreys.com>,
        linux-um@...ts.infradead.org
Subject: Re: [PATCH] LOCKDEP: use depends on LOCKDEP_SUPPORT instead of $ARCH
 list

On 5/17/21 3:11 AM, Ingo Molnar wrote:
> * Randy Dunlap <rdunlap@...radead.org> wrote:
>
>> Both arch/um/ and arch/xtensa/ cause a Kconfig warning for LOCKDEP.
>> These arch-es select LOCKDEP_SUPPORT but they are not listed as one
>> of the arch-es that LOCKDEP depends on.
>>
>> Since (16) arch-es define the Kconfig symbol LOCKDEP_SUPPORT if they
>> intend to have LOCKDEP support, replace the awkward list of
>> arch-es that LOCKDEP depends on with the LOCKDEP_SUPPORT symbol.
>>
>> Fixes this kconfig warning: (for both um and xtensa)
>>
>> WARNING: unmet direct dependencies detected for LOCKDEP
>>    Depends on [n]: DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] && (FRAME_POINTER [=n] || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86)
>>    Selected by [y]:
>>    - PROVE_LOCKING [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y]
>>    - LOCK_STAT [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y]
>>    - DEBUG_LOCK_ALLOC [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y]
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Peter Zijlstra <peterz@...radead.org>
>> Cc: Ingo Molnar <mingo@...hat.com>
>> Cc: Will Deacon <will@...nel.org>
>> Cc: Waiman Long <longman@...hat.com>
>> Cc: Boqun Feng <boqun.feng@...il.com>
>> Cc: Chris Zankel <chris@...kel.net>
>> Cc: Max Filippov <jcmvbkbc@...il.com>
>> Cc: linux-xtensa@...ux-xtensa.org
>> Cc: Johannes Berg <johannes@...solutions.net>
>> Cc: Jeff Dike <jdike@...toit.com>
>> Cc: Richard Weinberger <richard@....at>
>> Cc: Anton Ivanov <anton.ivanov@...bridgegreys.com>
>> Cc: linux-um@...ts.infradead.org
>> ---
>>   lib/Kconfig.debug |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20210514.orig/lib/Kconfig.debug
>> +++ linux-next-20210514/lib/Kconfig.debug
>> @@ -1383,7 +1383,7 @@ config LOCKDEP
>>   	bool
>>   	depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
>>   	select STACKTRACE
>> -	depends on FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86
>> +	depends on FRAME_POINTER || LOCKDEP_SUPPORT
> Ok - the FRAME_POINTER bit is weird. Are there any architectures that have
> FRAME_POINTER defined but no LOCKDEP_SUPPORT?

LOCK_DEBUGGING_SUPPORT depends on LOCKDEP_SUPPORT. So this patch is 
equivalent to just delete the second depends-on line. Beside LOCKDEP, 
LATENCYTOP also have exactly the same depends-on line.

So isn't FRAME_POINTER used mainly to support STACK_TRACE? However, 
LOCK_DEBUGGING_SUPPORT has already included STACK_TRACE_SUPPORT in its 
dependency. So why there is a FRAME_POINTER dependency?

Cheers,
Longman