linux-kernel - Re: [PATCH -next] rtc: m41t80: correct function names in rtc-m41t80.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6dc0bf7e-50d3-e8bb-d068-a8a9bbed6fa1@infradead.org>
Date:   Sun, 16 May 2021 22:07:28 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org
Cc:     a.zummo@...ertech.it, alexandre.belloni@...tlin.com
Subject: Re: [PATCH -next] rtc: m41t80: correct function names in rtc-m41t80.c

On 5/16/21 9:58 PM, Yang Yingliang wrote:
> Fix the following make W=1 kernel build warnings:
> 
>   drivers/rtc/rtc-m41t80.c:811: warning: expecting prototype for wdt_close(). Prototype was for wdt_release() instead
>   drivers/rtc/rtc-m41t80.c:830: warning: expecting prototype for notify_sys(). Prototype was for wdt_notify_sys() instead
> 
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Hi,
In kernel-doc notation, a function name should be followed by a '-',
not a ':'.  Please fix & resend.

Thanks.

> ---
>  drivers/rtc/rtc-m41t80.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
> index 89128fc29ccc..79512d1c828e 100644
> --- a/drivers/rtc/rtc-m41t80.c
> +++ b/drivers/rtc/rtc-m41t80.c
> @@ -802,7 +802,7 @@ static int wdt_open(struct inode *inode, struct file *file)
>  }
>  
>  /**
> - *	wdt_close:
> + *	wdt_release:
>   *	@inode: inode to board
>   *	@file: file handle to board
>   *
> @@ -815,7 +815,7 @@ static int wdt_release(struct inode *inode, struct file *file)
>  }
>  
>  /**
> - *	notify_sys:
> + *	wdt_notify_sys:
>   *	@this: our notifier block
>   *	@code: the event being reported
>   *	@unused: unused
> 


-- 
~Randy