linux-kernel - Re: [PATCH V4 7/8] arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a835d67abc8509f1e7de5f0afd330a1c@codeaurora.org>
Date:   Mon, 17 May 2021 10:58:37 +0530
From:   skakit@...eaurora.org
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, kgunda@...eaurora.org
Subject: Re: [PATCH V4 7/8] arm64: dts: qcom: sc7280: Add channel nodes for
 sc7280-idp

On 2021-05-05 20:16, Matthias Kaehlcke wrote:
> On Wed, May 05, 2021 at 12:25:25PM +0530, satya priya wrote:
> 
>> Subject: arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp
> 
> nit: just 'channel nodes' is a bit vague. In case you respin maybe
> change it to something like 'Add ADC channel nodes for PMIC
> temperatures to sc7280-idp'
> 

Okay will change it and resend v4.

> In any case it doesn't seem worth to respin just for this.
> 
>> 
>> Add channel nodes for the on die temperatures of PMICS
>> pmk8350, pm8350, pmr735a and pmr735b.
>> 
>> Signed-off-by: satya priya <skakit@...eaurora.org>
> 
> Reviewed-by: Matthias Kaehlcke <mka@...omium.org>