linux-kernel - Re: [PATCH v4 1/2] samples/kprobes: Fix typo in handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 May 2021 14:46:00 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Jonathan Corbet <corbet@....net>, Marc Koderer <marc@...erer.com>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Jisheng Zhang <jszhang@...nel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
        Ananth N Mavinakayanahalli <ananth@...ibm.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
        Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH v4 1/2] samples/kprobes: Fix typo in handler_fault()

On Mon, 17 May 2021 10:21:22 +0800
Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:

> Fix a defective format in handler_fault() ending with an 'n' that
> should be '\n'.
> 
> Fixes: 804defea1c02 ("Kprobes: move kprobe examples to samples/")
> Suggested-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>

Looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thank you!

> ---
>  samples/kprobes/kprobe_example.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> index c495664..d77a546 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -101,7 +101,7 @@ static void __kprobes handler_post(struct kprobe *p, struct pt_regs *regs,
>   */
>  static int handler_fault(struct kprobe *p, struct pt_regs *regs, int trapnr)
>  {
> -	pr_info("fault_handler: p->addr = 0x%p, trap #%dn", p->addr, trapnr);
> +	pr_info("fault_handler: p->addr = 0x%p, trap #%d\n", p->addr, trapnr);
>  	/* Return 0 because we don't handle the fault. */
>  	return 0;
>  }
> -- 
> 2.1.0
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>