linux-kernel - Re: [PATCH v1 1/2] of: base: Export of_device_compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210518181435.GB949047@robh.at.kernel.org>
Date:   Tue, 18 May 2021 13:14:35 -0500
From:   Rob Herring <robh@...nel.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Ion Agorria <ion@...rria.com>,
        Svyatoslav Ryhel <clamor95@...il.com>,
        Frank Rowand <frowand.list@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-tegra@...r.kernel.org, devicetree@...r.kernel.org,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] of: base: Export of_device_compatible_match()

On Tue, May 18, 2021 at 03:13:55AM +0300, Dmitry Osipenko wrote:
> The of_device_compatible_match() will be used by the updated NVIDIA Tegra
> ASoC WM8903 driver which could be build as a loadable module, export the
> OF function.
> 
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
>  drivers/of/base.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index 48e941f99558..eeca92467531 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -556,6 +556,7 @@ int of_device_compatible_match(struct device_node *device,
>  
>  	return score;
>  }
> +EXPORT_SYMBOL(of_device_compatible_match);

I should document this, but there's a number of of_* functions that have 
only a few users and I want to get rid of. This is one of them. Grep 
this function and you'll notice most should be using 
of_machine_is_compatible instead and we're left with sunxi_mbus...

Rob