linux-kernel - Re: [PATCH v10 2/5] USB: misc: Add onboard_usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210518194511.GA1137841@rowland.harvard.edu>
Date:   Tue, 18 May 2021 15:45:11 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        Michal Simek <michal.simek@...inx.com>,
        devicetree@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        linux-usb@...r.kernel.org, Peter Chen <peter.chen@...nel.org>,
        linux-kernel@...r.kernel.org, Stephen Boyd <swboyd@...omium.org>,
        Ravi Chandra Sadineni <ravisadineni@...omium.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Bastien Nocera <hadess@...ess.net>,
        Al Cooper <alcooperx@...il.com>,
        "Alexander A. Klimov" <grandmaster@...klimov.de>,
        Masahiro Yamada <masahiroy@...nel.org>
Subject: Re: [PATCH v10 2/5] USB: misc: Add onboard_usb_hub driver

On Tue, May 18, 2021 at 10:05:49AM -0700, Matthias Kaehlcke wrote:
> Hi Alan,
> 
> You seemed to have a generally favorable view of this driver,
> but I haven't heard from you in a while :)
> 
> On v4 expressed a series of suggestions and concerns, which
> should be addressed in this version:
> 
> https://lore.kernel.org/patchwork/patch/1313000/
> https://lore.kernel.org/patchwork/patch/1313001/
> 
> Rob acked the DT binding and the of_platform change. Please let me
> know if the USB part needs any further changes or if you think this
> series is ready to land.

Those were long and complicated threads, and a lot of the material has
gone out of my brain since last October.  :-(

Still, at the time when this was first posted I don't remember there
being any big outstanding issues regarding the USB part of the
implementation.  It seemed to be pretty much all in order.

You can add:

Acked-by: Alan Stern <stern@...land.harvard.edu>

to this patch.  Greg KH may have some thoughts of his own...

Alan Stern