linux-kernel - Re: [PATCH 06/11] net: intel: iwlwifi: Demote non-compliant kernel-doc headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 May 2021 11:08:49 +0800
From:   Yang Shen <shenyang39@...wei.com>
To:     Luca Coelho <luciano.coelho@...el.com>
CC:     <kvalo@...eaurora.org>, <linux-wireless@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Stanislav Yakovlev <stas.yakovlev@...il.com>
Subject: Re: [PATCH 06/11] net: intel: iwlwifi: Demote non-compliant
 kernel-doc headers

Hello:

I'm sorry for getting wrong maintainer information.

Best Regards,
     Yang

On 2021/5/17 13:01, Yang Shen wrote:
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:11: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>  drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> Cc: Stanislav Yakovlev <stas.yakovlev@...il.com>
> Signed-off-by: Yang Shen <shenyang39@...wei.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/mvm/rfi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
> index 0b818067067c..f1ed73c9f3dd 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
> @@ -7,11 +7,11 @@
>  #include "fw/api/commands.h"
>  #include "fw/api/phy-ctxt.h"
>
> -/**
> +/*
>   * DDR needs frequency in units of 16.666MHz, so provide FW with the
>   * frequency values in the adjusted format.
>   */
> -const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
> +static const struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
>  	/* LPDDR4 */
>
>  	/* frequency 3733MHz */
> --
> 2.17.1
>
> .
>