linux-kernel - Re: [PATCH] pinctrl: single: config: enable the pin's input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YKNZ0A7umnk4LwKU@atomide.com>
Date:   Tue, 18 May 2021 09:08:16 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     Dario Binacchi <dariobin@...ero.it>
Cc:     linux-kernel@...r.kernel.org,
        Haojian Zhuang <haojian.zhuang@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH] pinctrl: single: config: enable the pin's input

* Dario Binacchi <dariobin@...ero.it> [210514 16:38]:
> It enables / disables the input buffer. As explained in the description
> of 'enum pin_config_param' this does not affect the pin's ability to
> drive output.
> 
> Signed-off-by: Dario Binacchi <dariobin@...ero.it>
> ---
> 
>  drivers/pinctrl/pinctrl-single.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index 2c9c9835f375..4e7cdb9ee855 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -534,6 +534,7 @@ static int pcs_pinconf_get(struct pinctrl_dev *pctldev,
>  		case PIN_CONFIG_DRIVE_STRENGTH:
>  		case PIN_CONFIG_SLEW_RATE:
>  		case PIN_CONFIG_MODE_LOW_POWER:
> +		case PIN_CONFIG_INPUT_ENABLE:
>  		default:
>  			*config = data;
>  			break;
> @@ -572,6 +573,7 @@ static int pcs_pinconf_set(struct pinctrl_dev *pctldev,
>  			case PIN_CONFIG_DRIVE_STRENGTH:
>  			case PIN_CONFIG_SLEW_RATE:
>  			case PIN_CONFIG_MODE_LOW_POWER:
> +			case PIN_CONFIG_INPUT_ENABLE:
>  				shift = ffs(func->conf[i].mask) - 1;
>  				data &= ~func->conf[i].mask;
>  				data |= (arg << shift) & func->conf[i].mask;
> @@ -918,6 +920,7 @@ static int pcs_parse_pinconf(struct pcs_device *pcs, struct device_node *np,
>  	static const struct pcs_conf_type prop2[] = {
>  		{ "pinctrl-single,drive-strength", PIN_CONFIG_DRIVE_STRENGTH, },
>  		{ "pinctrl-single,slew-rate", PIN_CONFIG_SLEW_RATE, },
> +		{ "pinctrl-single,input-enable", PIN_CONFIG_INPUT_ENABLE, },
>  		{ "pinctrl-single,input-schmitt", PIN_CONFIG_INPUT_SCHMITT, },
>  		{ "pinctrl-single,low-power-mode", PIN_CONFIG_MODE_LOW_POWER, },
>  	};

Looks OK to me if this works for Linus W. You need another patch to
update the binding though:

Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml

Or if there is such a patch floating around, I was not in Cc :)

Regards,

Tony