linux-kernel - Re: [PATCH tip:irq/core v1] genirq: remove auto-set of the mask when setting the hint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87im3gewlu.ffs@nanos.tec.linutronix.de>
Date:   Tue, 18 May 2021 02:03:57 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Nitesh Lal <nilal@...hat.com>
Cc:     Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Robin Murphy <robin.murphy@....com>,
        Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org, jbrandeb@...nel.org,
        "frederic\@kernel.org" <frederic@...nel.org>,
        "juri.lelli\@redhat.com" <juri.lelli@...hat.com>,
        Marcelo Tosatti <mtosatti@...hat.com>,
        Alex Belits <abelits@...vell.com>,
        "linux-api\@vger.kernel.org" <linux-api@...r.kernel.org>,
        "bhelgaas\@google.com" <bhelgaas@...gle.com>,
        "linux-pci\@vger.kernel.org" <linux-pci@...r.kernel.org>,
        "rostedt\@goodmis.org" <rostedt@...dmis.org>,
        "peterz\@infradead.org" <peterz@...radead.org>,
        "davem\@davemloft.net" <davem@...emloft.net>,
        "akpm\@linux-foundation.org" <akpm@...ux-foundation.org>,
        "sfr\@canb.auug.org.au" <sfr@...b.auug.org.au>,
        "stephen\@networkplumber.org" <stephen@...workplumber.org>,
        "rppt\@linux.vnet.ibm.com" <rppt@...ux.vnet.ibm.com>,
        "jinyuqi\@huawei.com" <jinyuqi@...wei.com>,
        "zhangshaokun\@hisilicon.com" <zhangshaokun@...ilicon.com>,
        netdev@...r.kernel.org, chris.friesen@...driver.com,
        Marc Zyngier <maz@...nel.org>,
        Neil Horman <nhorman@...driver.com>
Subject: Re: [PATCH tip:irq/core v1] genirq: remove auto-set of the mask when setting the hint

On Mon, May 17 2021 at 18:44, Nitesh Lal wrote:
> On Mon, May 17, 2021 at 4:48 PM Thomas Gleixner <tglx@...utronix.de> wrote:
>> The hint was added so that userspace has a better understanding where it
>> should place the interrupt. So if irqbalanced ignores it anyway, then
>> what's the point of the hint? IOW, why is it still used drivers?
>>
> Took a quick look at the irqbalance repo and saw the following commit:
>
> dcc411e7bf    remove affinity_hint infrastructure
>
> The commit message mentions that "PJ is redesiging how affinity hinting
> works in the kernel, the future model will just tell us to ignore an IRQ,
> and the kernel will handle placement for us.  As such we can remove the
> affinity_hint recognition entirely".

No idea who PJ is. I really love useful commit messages. Maybe Neil can
shed some light on that.

> This does indicate that apparently, irqbalance moved away from the usage of
> affinity_hint. However, the next question is what was this future
> model?

I might have missed something in the last 5 years, but that's the first
time I hear about someone trying to cleanup that thing.

> I don't know but I can surely look into it if that helps or maybe someone
> here already knows about it?

I CC'ed Neil :)

>> Now there is another aspect to that. What happens if irqbalanced does
>> not run at all and a driver relies on the side effect of the hint
>> setting the initial affinity. Bah...
>>
>
> Right, but if they only rely on this API so that the IRQs are spread across
> all the CPUs then that issue is already resolved and these other drivers
> should not regress because of changing this behavior. Isn't it?

Is that true for all architectures?

>> While none of the drivers (except the perf muck) actually prevents
>> userspace from fiddling with the affinity (via IRQF_NOBALANCING) a
>> deeper inspection shows that they actually might rely on the current
>> behaviour if irqbalanced is disabled. Of course every driver has its own
>> convoluted way to do that and all of those functions are well
>> documented. What a mess.
>>
>> If the hint still serves a purpose then we can provide a variant which
>> solely applies the hint and does not fiddle with the actual affinity,
>> but if the hint is useless anyway then we have a way better option to
>> clean that up.
>>
>
> +1

= 1

Thanks,

        tglx