linux-kernel - Re: [PATCH v2 1/2] regulator: fan53880: Fix missing n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a8fad66288f38a3dacd5dc23cee62bf3e3e6d5f.camel@googlemail.com>
Date:   Tue, 18 May 2021 14:00:25 +0200
From:   Christoph Fritz <chf.fritz@...glemail.com>
To:     Axel Lin <axel.lin@...ics.com>, Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] regulator: fan53880: Fix missing n_voltages
 setting

On Mon, 2021-05-17 at 18:53 +0800, Axel Lin wrote:
> Fixes: e6dea51e2d41 ("regulator: fan53880: Add initial support")
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Acked-by: Christoph Fritz <chf.fritz@...glemail.com>

> ---
> v2: address Christoph' comment
>  drivers/regulator/fan53880.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/regulator/fan53880.c b/drivers/regulator/fan53880.c
> index e83eb4fb1876..1684faf82ed2 100644
> --- a/drivers/regulator/fan53880.c
> +++ b/drivers/regulator/fan53880.c
> @@ -51,6 +51,7 @@ static const struct regulator_ops fan53880_ops = {
>  		      REGULATOR_LINEAR_RANGE(800000, 0xf, 0x73, 25000),	\
>  		},							\
>  		.n_linear_ranges = 2,					\
> +		.n_voltages =	   0x74,				\
>  		.vsel_reg =	   FAN53880_LDO ## _num ## VOUT,	\
>  		.vsel_mask =	   0x7f,				\
>  		.enable_reg =	   FAN53880_ENABLE,			\
> @@ -76,6 +77,7 @@ static const struct regulator_desc
> fan53880_regulators[] = {
>  		      REGULATOR_LINEAR_RANGE(600000, 0x1f, 0xf7, 12500),
>  		},
>  		.n_linear_ranges = 2,
> +		.n_voltages =	   0xf8,
>  		.vsel_reg =	   FAN53880_BUCKVOUT,
>  		.vsel_mask =	   0x7f,
>  		.enable_reg =	   FAN53880_ENABLE,
> @@ -95,6 +97,7 @@ static const struct regulator_desc
> fan53880_regulators[] = {
>  		      REGULATOR_LINEAR_RANGE(3000000, 0x4, 0x70, 25000),
>  		},
>  		.n_linear_ranges = 2,
> +		.n_voltages =	   0x71,
>  		.vsel_reg =	   FAN53880_BOOSTVOUT,
>  		.vsel_mask =	   0x7f,
>  		.enable_reg =	   FAN53880_ENABLE_BOOST,