linux-kernel - Re: [PATCH 1/1] regmap-irq: Introduce inverted status registers support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 May 2021 13:06:40 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Maxim Kochetkov <fido_max@...ox.ru>
Cc:     linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        rafael@...nel.org
Subject: Re: [PATCH 1/1] regmap-irq: Introduce inverted status registers
 support

On Tue, May 18, 2021 at 12:44:41PM +0300, Maxim Kochetkov wrote:

> +	if (chip->status_invert)
> +		for (i = 0; i < data->chip->num_regs; i++)
> +			data->status_buf[i] = ~data->status_buf[i];
> +

This is the only active change so this only affects readback meaning
that if both read and write are inverted this won't do what's expected,
breaking acks.  I'm guessing your device either mixes things or is clear
on read?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)