linux-kernel - Re: [PATCH v6 1/4] string_helpers: Escape double quotes in escape

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YKPK2gT+W8Eu04ND@chrisdown.name>
Date:   Tue, 18 May 2021 15:10:34 +0100
From:   Chris Down <chris@...isdown.name>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, Petr Mladek <pmladek@...e.com>,
        Jessica Yu <jeyu@...nel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        John Ogness <john.ogness@...utronix.de>,
        Steven Rostedt <rostedt@...dmis.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Kees Cook <keescook@...omium.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>, kernel-team@...com
Subject: Re: [PATCH v6 1/4] string_helpers: Escape double quotes in
 escape_special

Andy Shevchenko writes:
>We have only one direct user of ESCAPE_SPECIAL and there " is not used.
>
>Indirect ones are %pE, but IIRC most of them are either debug messages or some
>kind of (non-ABI) messages.
>
>It would be nice if you can confirm this and put a note into commit message.
>
>If the above is confirmed, feel free to add mine
>Reviewed-by; Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Thanks for reviewing! :-) I will triple check that and add for v7.