linux-kernel - Re: [PATCH] x86/i8259: Work around buggy legacy PIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a6osdozz.ffs@nanos.tec.linutronix.de>
Date:   Tue, 18 May 2021 17:45:52 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Sachi King <nakato@...ato.io>,
        Maximilian Luz <luzmaximilian@...il.com>
Cc:     "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        David Laight <David.Laight@...lab.com>,
        "x86\@kernel.org" <x86@...nel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Sasha Levin <sashal@...nel.org>,
        Tom Lendacky <thomas.lendacky@....com>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH] x86/i8259: Work around buggy legacy PIC

Sachi,

On Wed, May 19 2021 at 05:58, Sachi King wrote:
> On Tuesday, May 18, 2021 9:27:02 AM AEST Thomas Gleixner wrote:
>> On Mon, May 17 2021 at 21:25, Maximilian Luz wrote:
>> > On 5/17/21 8:40 PM, Thomas Gleixner wrote:
>> >> Can you please add "apic=verbose" to the kernel command line and provide
>> >> full dmesg output for a kernel w/o your patch and one with your patch
>> >> applied?
>
> I've linked to a dmesg with "apic=verbose" below with the irq 7 override hack 
> applied.  Would you still like a copy without either of these patches
> applied?

No, that's pretty conclusive.

> What's the convention for including a dmesg on the mailing list?  I've 
> included the copy via gist as pasting it into email seems incorrect, but 
> that's also probably not the correct convention.

That's fine.

>> Sachi, can you please try the hack below to confirm the above?
>>
>> It's not meant to be a solution, but it's the most trivial way to
>> validate this.
>
> I've applied that patch and the GPIO driver loads and functions.

It's exactly what I expected. So now for a proper solution. After
talking to Raphael it seems something like that quirk is the best option
we have. I'll try to come up with something less horrible. There is some
other minor issue I noticed, which I need to look at as well.

Thanks for digging into this and for testing!

       tglx